This repository was archived by the owner on Jun 18, 2024. It is now read-only.
Fix edit path for files in folders #387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
+1 |
|
Thanks! |
philipashlock
added a commit
that referenced
this pull request
Nov 4, 2014
Fix edit path for files in folders
philipashlock
added a commit
that referenced
this pull request
Nov 4, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The edit link currently breaks for files in folders. If you visit https://project-open-data.cio.gov/v1.1/schema/ and click "Help Improve this Content", it will take you to the editing screen for the top-level
schema.md, notv1.1/schema.md.This uses
page.pathinstead ofpage.filename, which incorporates the full path to that file. It's documented here and cites formulating edit links as a main use case.